Remove unused max_position_embeddings in config classes#20836
Merged
Conversation
ydshieh
requested review from
LysandreJik,
NielsRogge and
sgugger
and removed request for
sgugger
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Dec 20, 2022
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Thanks for cleaning this!
silverriver
pushed a commit
to silverriver/transformers
that referenced
this pull request
Jan 6, 2023
…ce#20836) Removed unused max_position_embeddings in config classes Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Similar to #20596 and #20554, but here we removed unused
max_position_embeddings.